[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 5/6] conf: Ignore the volume type disk if its mode is "uri"



On 06/18/2013 04:36 AM, Osier Yang wrote:
> virDomainDiskDefForeachPath is not only used by the security
> setting helpers, also used by cgroup setting helpers, so this
> is to ignore the volume type disk with mode="uri" for cgroup
> setting.
> ---
>  src/conf/domain_conf.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 

Seems reasonable, ACK.  Should I assume you checked all uses of
VIR_DOMAIN_DISK_TYPE_NETWORK to make sure none of the others make
similar checks that this volume source pool URI will also need to avoid.

John



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]