[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 1/2] BSD: implement virNetDevBridgeCreate() and virNetDevBridgeDelete()



  Jiri Denemark wrote:

> On Wed, Jun 19, 2013 at 20:47:30 +0400, Roman Bogorodskiy wrote:
> > Implementation uses SIOCIFCREATE2 and SIOCIFDESTROY ioctls.
> > Also, drop static virNetDevSetupControl() as we have
> > public one avialable now.
> > ---
> >  src/util/virnetdevbridge.c | 91 ++++++++++++++++++++++++----------------------
> >  1 file changed, 48 insertions(+), 43 deletions(-)
> 
> Looks good and it still compiles on linux :-)
> 
> ACK to both patches and pushed, thanks.

Unfortunately I've just noticed that I made a sad mistake. :(

virNetDevBridgeSetSTPDelay expects delay in milliseconds but I have
implemented in expecting seconds.

I'll send a fix tomorrow, sorry about that.

Roman Bogorodskiy

Attachment: pgpaxpEscvDjj.pgp
Description: PGP signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]