[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

[libvirt] [PATCH] Get rid of useless VIR_STORAGE_FILE_FEATURE_NONE



It's not used anywhere except for the switch in
virStorageBackendCreateQemuImgOpts, where leaving it in causes
a dead code coverity warning and omitting it breaks compilation
because of unhandled enum value.

Introduced by 6298f74.
---
Pushed as trivial.

 src/storage/storage_backend.c | 2 +-
 src/util/virstoragefile.h     | 3 +--
 2 files changed, 2 insertions(+), 3 deletions(-)

diff --git a/src/storage/storage_backend.c b/src/storage/storage_backend.c
index 27a0a4f..ae25c89 100644
--- a/src/storage/storage_backend.c
+++ b/src/storage/storage_backend.c
@@ -666,7 +666,7 @@ virStorageBackendCreateQemuImgOpts(char **opts,
                         goto error;
                     }
                     break;
-                case VIR_STORAGE_FILE_FEATURE_NONE:
+
                 case VIR_STORAGE_FILE_FEATURE_LAST:
                     ;
                 }
diff --git a/src/util/virstoragefile.h b/src/util/virstoragefile.h
index a848fd0..4cb47e6 100644
--- a/src/util/virstoragefile.h
+++ b/src/util/virstoragefile.h
@@ -53,8 +53,7 @@ enum virStorageFileFormat {
 VIR_ENUM_DECL(virStorageFileFormat);
 
 enum virStorageFileFeature {
-    VIR_STORAGE_FILE_FEATURE_NONE = -1,
-    VIR_STORAGE_FILE_FEATURE_LAZY_REFCOUNTS,
+    VIR_STORAGE_FILE_FEATURE_LAZY_REFCOUNTS = 0,
 
     VIR_STORAGE_FILE_FEATURE_LAST
 };
-- 
1.8.1.5


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]