[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCHv2 06/12] pci: eliminate repetitive path constructions in virPCIDeviceBindToStub



On Mon, Jun 24, 2013 at 11:05:32PM -0400, Laine Stump wrote:
> The same strings were being re-created multiple times just to save
> declaring a new variable. In the meantime, the use of the generic
> variable names led to confusion when trying to follow the code. This
> patch creates strings for:
> 
>  stubDriverName  (was called "driver" in original args)
>  stubDriverPath  ("/sys/bus/pci/drivers/${stubDriverName}")
>  driverLink      ("${device}/driver")
>  oldDriverName   (the final component of path linked to by
>                   "${device}/driver")
>  oldDriverPath   ("/sys/bus/pci/drivers/${oldDriverName}")
> 
> then re-uses them as necessary.
> ---
>  src/util/virpci.c | 73 ++++++++++++++++++++++++++++---------------------------
>  1 file changed, 37 insertions(+), 36 deletions(-)

ACK

Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]