[libvirt] [PATCH 15/21] Adapt virDomainMigrateVersion3 for extensible migration APIs
Jiri Denemark
jdenemar at redhat.com
Tue Jun 25 14:25:54 UTC 2013
On Tue, Jun 25, 2013 at 06:56:35 -0400, John Ferlan wrote:
> On 06/18/2013 10:05 AM, Jiri Denemark wrote:
> > ---
> > src/libvirt.c | 177 +++++++++++++++++++++++++++++++++++++++++++---------------
> > 1 file changed, 133 insertions(+), 44 deletions(-)
> >
>
> <...snip...>
>
>
> > + if (useParams) {
> > + if (virTypedParamsGetString(params, nparams,
> > + VIR_MIGRATE_PARAM_DEST_NAME, NULL) <= 0 &&
> > + virTypedParamsReplaceString(¶ms, &nparams,
> > + VIR_MIGRATE_PARAM_DEST_NAME,
> > + domain->name) < 0) {
> > + domain = NULL;
>
>
> ^^^ The setting of NULL right here causes Coverity problems later...
Oops, that's a nasty typo. Fixed by the following patch which I pushed
as trivial:
diff --git a/src/libvirt.c b/src/libvirt.c
index 2dc96a9..bc1694a 100644
--- a/src/libvirt.c
+++ b/src/libvirt.c
@@ -4979,7 +4979,7 @@ finish:
virTypedParamsReplaceString(¶ms, &nparams,
VIR_MIGRATE_PARAM_DEST_NAME,
domain->name) < 0) {
- domain = NULL;
+ ddomain = NULL;
} else {
ddomain = dconn->driver->domainMigrateFinish3Params
(dconn, params, nparams, cookiein, cookieinlen,
More information about the libvir-list
mailing list