[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] add support for libssh2 password from auth file



On Fri, Jun 28, 2013 at 01:50:08PM +0200, Michal Novotny wrote:
> 
> On 06/28/2013 01:48 PM, Daniel P. Berrange wrote:
> > On Fri, Jun 28, 2013 at 01:43:44PM +0200, Michal Novotny wrote:
> >> if libvirt doesn't have the tokenizer support yet, it may be a good RFE
> >> as I believe it could be really useful ;-)
> >>
> >> Peter, do you know about anything libvirt supports to tokenize string?
> > We have virStringSplit for tokenizing strings which have a fixed
> > separator.
> >
> >
> > Daniel
> 
> That sounds good, however what about splitting the function to 2
> separate functions, one accepting the second parameter as the separator,
> called e.g. virStringSplitBy() and second just calling the first one
> with the fixed separator?
> 
> Wouldn't it be better?

That sounds like overkill to me unless we have a clear need for it
somewhere in our code.


Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]