[libvirt] [Libvirt-announce] Candidate release 2 for libvirt-1.1.0

[Daniel P. Berrange]

On Fri, Jun 28, 2013 at 03:01:58PM +0100, Justin Clift wrote:
> On 27/06/2013, at 5:01 PM, Daniel Veillard wrote:
> >   I have just tagged the release candidate 2 in git and sent a tarball
> > to the usual place (rpms are coming):
> >   ftp://libvirt.org/libvirt/
> 
> Sorry for the delay, only just now remembered to test this. :)
> 
> Compilation is failing on OSX 10.7 x64 with:
> 
> **************************************************************
>   CC     libvirt_util_la-virnetdevveth.lo
>   CC     libvirt_util_la-virnetdevvlan.lo
>   CC     libvirt_util_la-virnetdevvportprofile.lo
>   CC     libvirt_util_la-virnetlink.lo
>   CC     libvirt_util_la-virnodesuspend.lo
>   CC     libvirt_util_la-virnuma.lo
> util/virnetdevtap.c:315:26: error: use of undeclared identifier 'IF_MAXUNIT'
>         for (i = 0; i <= IF_MAXUNIT; i++) {

[snip]

> Googling shows IF_MAXUNIT in context of FreeBSD stuff.  Not sure
> of the right approach here.  eg exclude compiling this on OSX,
> or alternatively make-it-work on OSX.

Yes, this is from code that is only designed to work on FreeBSD. I
guess the OS-X BSD base isn't close enough to support this properly.

Try this patch

diff --git a/src/util/virnetdevtap.c b/src/util/virnetdevtap.c
index 265676c..4e2f32a 100644
--- a/src/util/virnetdevtap.c
+++ b/src/util/virnetdevtap.c
@@ -275,7 +275,7 @@ cleanup:
     VIR_FORCE_CLOSE(fd);
     return ret;
 }
-#elif defined(SIOCIFCREATE2) && defined(SIOCIFDESTROY)
+#elif defined(SIOCIFCREATE2) && defined(SIOCIFDESTROY) && defined(IF_MAXUNIT)
 int virNetDevTapCreate(char **ifname,
                        int *tapfd,
                        int tapfdSize,


Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|