[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] Fix error report from nl_recvmsg



On 03/01/2013 03:18 AM, Daniel P. Berrange wrote:
>>
>> So the conclusion is that I see no extra harm in calling nl_geterror(). ACK.
> 
> Except the API signature is different, so my patch won't work with
> both versions :-(

Sounds like its time for a wrapper function that #ifdefs away the
difference in underlying API calls between libnl1 and libnl3, with the
bulk of our code using our wrapper instead of direct nl_* functions.
And by the time we convert our code to all go through our wrappers, how
much simpler is it to have our wrapper do the direct socket work instead
of catering to two parallel nl_ abstractions?

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]