[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] util: use string libvirt to prefix error message instead of libvir



On Mon, Mar 04, 2013 at 08:54:10PM +0800, Guannan Ren wrote:
> BZ:https://bugzilla.redhat.com/show_bug.cgi?id=912021
> Without error handler set, virDefaultErrorFunc will be called, the
> error message is prefixed with "libvir:". It become a little better
> by using prefix "libvirt:" when working with upper application.

My concern is that making this change could break scripts that depend
on the old spelling.  Guannan mentioned to me that this error doesn't
arise when using virsh.  I don't have a strong opinion either way, but
I think if there's no danger of breaking existing code that depends on
the spelling then we should fix this, otherwise leave it as is.

Dave


> For example:
> 1, stop libvirtd daemon
> 2, run virt-top.
> libvir: XML-RPC error : Failed to connect \
>         socket to '/var/run/libvirt/libvirt-sock-ro': \
>         No such file or directory
> libvirt: VIR_ERR_SYSTEM_ERROR: VIR_FROM_RPC: \
>         Failed to connect socket to '/var/run/libvirt/libvirt-sock-ro': \
>         No such file or directory
> ---
>  src/util/virerror.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/src/util/virerror.c b/src/util/virerror.c
> index 301a1ac..40c3b25 100644
> --- a/src/util/virerror.c
> +++ b/src/util/virerror.c
> @@ -525,13 +525,13 @@ virDefaultErrorFunc(virErrorPtr err)
>      len = strlen(err->message);
>      if ((err->domain == VIR_FROM_XML) && (err->code == VIR_ERR_XML_DETAIL) &&
>          (err->int1 != 0))
> -        fprintf(stderr, "libvir: %s %s %s%s: line %d: %s",
> +        fprintf(stderr, "libvirt: %s %s %s%s: line %d: %s",
>                  dom, lvl, domain, network, err->int1, err->message);
>      else if ((len == 0) || (err->message[len - 1] != '\n'))
> -        fprintf(stderr, "libvir: %s %s %s%s: %s\n",
> +        fprintf(stderr, "libvirt: %s %s %s%s: %s\n",
>                  dom, lvl, domain, network, err->message);
>      else
> -        fprintf(stderr, "libvir: %s %s %s%s: %s",
> +        fprintf(stderr, "libvirt: %s %s %s%s: %s",
>                  dom, lvl, domain, network, err->message);
>  }
>  
> -- 
> 1.7.11.2
> 
> --
> libvir-list mailing list
> libvir-list redhat com
> https://www.redhat.com/mailman/listinfo/libvir-list


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]