[libvirt] [PATCH] util: use string libvirt to prefix error message instead of libvir

[Guannan Ren]

On 03/04/2013 10:53 PM, Daniel P. Berrange wrote:
> On Mon, Mar 04, 2013 at 09:50:23AM -0500, Dave Allan wrote:
>> On Mon, Mar 04, 2013 at 08:54:10PM +0800, Guannan Ren wrote:
>>> BZ:https://bugzilla.redhat.com/show_bug.cgi?id=912021
>>> Without error handler set, virDefaultErrorFunc will be called, the
>>> error message is prefixed with "libvir:". It become a little better
>>> by using prefix "libvirt:" when working with upper application.
>> My concern is that making this change could break scripts that depend
>> on the old spelling.  Guannan mentioned to me that this error doesn't
>> arise when using virsh.  I don't have a strong opinion either way, but
>> I think if there's no danger of breaking existing code that depends on
>> the spelling then we should fix this, otherwise leave it as is.
> The reason it doesn't hurt virsh is that it disabled the default
> error reporting function. It reports errors directly itself. In
> fact most apps end up disabling the default error reporting
> function & doing their own error reporting to stderr, because
> the default is not flexible enough.
>
> /me wishes we didn't ever have it in the first place - libraries
> have no business printing anything to stderr, without explicit
> app opt-in.
>
> I think it would be ok to rename this though. Apps relying on
> screen-scraping this text are doomed - we've never considered
> error message text to be part of the stable interface, nor
> even error codes - we'll often change codes to better ones over
> time.
>
> Daniel

    Thanks, pushed

    Guannan