[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] Add NUMA memory information to virsh capabilities output.



On Thu, Mar 07, 2013 at 12:13:30AM -0500, Dusty Mabe wrote:
> On Wed, Mar 6, 2013 at 5:07 PM, Daniel P. Berrange <berrange redhat com> wrote:
> > On Thu, Feb 14, 2013 at 12:52:38PM -0500, Dusty Mabe wrote:
> >>
> >> +    if (numa_available() < 0) {
> >> +        virReportError(VIR_ERR_INTERNAL_ERROR,
> >> +                       "%s", _("NUMA not supported on this host"));
> >> +        goto cleanup;
> >> +    }
> >
> > This check isn't needed since you're calling this from
> > nodeInitNUMA which has already done exactly this check
> 
> Thanks for the comments! I have removed this check from the code.
> Should I generate a new patch email with the finalized code? I assume
> that I should do a git pull --rebase first. Please let me know if that
> is not the case.

Yep, just rebase to latest git master & repost.

Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]