[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCHv2 00/21] Driver XML conf adjustment callbacks [READ FIRST]



On 06.03.2013 16:37, Peter Krempa wrote:
> This series implements the driver XML parsing callbacks as
> Dan suggested.
> 
> This series may appear to be monstrous but I chose to split some patches
> to separate ones although the code does not compile afterwards to ease review.
> 
> The patches starting with the word "fix" will need to be squashed into the
> non "fix" patches predceeding them.
> 
> The last patch demonstrates the use of this code to get rid of the rest
> of the irrelevant fields in virCaps. I didn't go further with those
> to save time if there's a design flaw in the callback stuff.


My overall feeling is - I like it. I think it will help us in
autogenerating driver dependent values, e.g. paths for unix sockets :)

So take this as my ACK. But, please wait a while (till Monday at least)
to see if somebody thinks otherwise.

Michal


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]