[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 6/7] Ensure xmlSaveToBuffer is always defined



On 03/07/2013 10:58 AM, Daniel P. Berrange wrote:
> 
> Hmm, why does vshCompleteXMLFromDomain exist at all, if nothgin is
> calling it. We should just delete it.

Ah, that's leftover code from earlier attempts to make virsh
canonicalize XML, which we had to revert because it was only a
half-baked approach at the time:
https://www.redhat.com/archives/libvir-list/2012-February/msg00365.html

Until we actually ever get code that works for turning a user's partial
description into an unambiguous device XML, deleting the unused function
probably won't hurt (after all, we have git history and can revive it).

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]