[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] util: escapes special characters in VIR_LOG_REGEX



On 03/11/2013 10:10 AM, Osier Yang wrote:
On 2013年03月09日 22:49, Guannan Ren wrote:
In debug mode, the bug failed to start vm
error: Failed to start domain rhel5u9
error: internal error Out of space while reading console log output:

It's hard to known why the old regex cause error like this, as they
looks quite unrelated. Can you explain more?


After turning debug mode on, the qemu process redirects its standard output into log file: eg /var/log/libvirt/qemu/rhel5u9.log with lots of debugging log messages included. The regular expression is used to filter out these debugging log messages to get PTY device used by the qemu instance like /dev/pts/10 in "char device redirected to /dev/pts/10" libvirtd reads data from the log file into a buffer with 4096 size, if the RE doesn't work, the buffer is easily out of space before getting the pty device. If it works, the buffer only contains the device info, however, all of debugging log message strings are filtered out.
       The patch fix the failure of the RE.

    Guannan



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]