[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCHv3 20/27] fix fallout from adding new parameter to internal APIs



On Mon, Mar 11, 2013 at 04:06:31PM +0100, Peter Krempa wrote:
> ---
>  src/conf/domain_conf.c     |  4 +++-
>  src/conf/domain_conf.h     |  2 ++
>  src/libxl/libxl_driver.c   |  6 ++++--
>  src/lxc/lxc_driver.c       |  6 ++++--
>  src/openvz/openvz_driver.c |  4 ++--
>  src/phyp/phyp_driver.c     |  4 ++--
>  src/qemu/qemu_driver.c     | 11 +++++++----
>  src/uml/uml_driver.c       |  4 ++--
>  src/vbox/vbox_tmpl.c       |  8 ++++----
>  src/xen/xend_internal.c    |  6 +++---
>  src/xen/xm_internal.c      |  2 ++
>  11 files changed, 35 insertions(+), 22 deletions(-)

ACK, I'm really not finding it helpful to have this code split out for
review. Please just post patches which are self-contained and compile.
It is not nice reviewing one patch, to identify a problem and then
search through later "fixup" patches to see if it is fixed or not.

Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]