[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] Fix missing error dispatch in virDomainLxcEnterNamespace



On 03/12/2013 11:37 AM, Daniel P. Berrange wrote:
> From: "Daniel P. Berrange" <berrange redhat com>
> 
> The virDomainLxcEnterNamespace method mistakenly uses
> virCheckFlags, which returns immediately instead of
> virCheckFlagsGoto which jumps to the error cleanup
> patch where there is a virDispatchError call
> ---
>  src/libvirt-lxc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

ACK.

> 
> diff --git a/src/libvirt-lxc.c b/src/libvirt-lxc.c
> index c1bf168..abbbc12 100644
> --- a/src/libvirt-lxc.c
> +++ b/src/libvirt-lxc.c
> @@ -138,7 +138,7 @@ virDomainLxcEnterNamespace(virDomainPtr domain,
>  {
>      int i;
>  
> -    virCheckFlags(0, -1);
> +    virCheckFlagsGoto(0, error);
>  
>      if (noldfdlist && oldfdlist) {
>          size_t nfds;
> 

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]