[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v3 1/4] QEMU: add -dtb option support



Hi Daniel,

Thanks. I've submit v4 version of these patches.

Best Regards,
Olivia

> -----Original Message-----
> From: Daniel P. Berrange [mailto:berrange redhat com]
> Sent: Thursday, February 28, 2013 1:08 AM
> To: Yin Olivia-R63875
> Cc: libvir-list redhat com
> Subject: Re: [libvirt] [PATCH v3 1/4] QEMU: add -dtb option support
> 
> On Wed, Feb 27, 2013 at 04:28:37PM +0800, Olivia Yin wrote:
> > Signed-off-by: Olivia Yin <hong-hua yin freescale com>
> > ---
> >  src/conf/domain_conf.c  |    4 ++++
> >  src/conf/domain_conf.h  |    1 +
> >  src/qemu/qemu_command.c |    6 ++++++
> >  3 files changed, 11 insertions(+), 0 deletions(-)
> 
> The split of code across your patches is sub-optimal. We prefer to keep
> changes to the XML parser/formatter separate from changes to drivers.
> 
> Also the code to test the QEMU driver should be in the same patch as the
> patch which changes the command line parser.
> 
> So what you really want is 2 patches. One with domain_conf.{c,h} changes,
> RNG schema addition & schema documentation, and the other patch with all
> the QEMU driver changes + testing
> 
> 
> Daniel
> --
> |: http://berrange.com      -o-
> http://www.flickr.com/photos/dberrange/ :|
> |: http://libvirt.org              -o-             http://virt-
> manager.org :|
> |: http://autobuild.org       -o-
> http://search.cpan.org/~danberr/ :|
> |: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-
> vnc :|



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]