[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCHv4 4/5] S390: Add hotplug support for s390 virtio devices



On Tue, Mar 05, 2013 at 04:44:22PM +0100, Viktor Mihajlovski wrote:
> From: "J.B. Joret" <jb linux vnet ibm com>
> 
> We didn't yet expose the virtio device attach and detach functionality
> for s390 domains as the device hotplug was very limited with the old
> virtio-s390 bus. With the CCW bus there's full hotplug support for
> virtio devices in QEMU, so we are adding this to libvirt too.
> 
> Since the virtio hotplug isn't limited to PCI anymore, we change the
> function names from xxxPCIyyy to xxxVirtioyyy, where we handle all
> three virtio bus types.
> 
> Signed-off-by: J.B. Joret <jb linux vnet ibm com>
> Signed-off-by: Viktor Mihajlovski <mihajlov linux vnet ibm com>
> ---
> V2 Changes
>  - rebase, mainly addressing the rename of qemuCapsXXX to virQEMUCapsXXX 
> 
> V3 Changes
>  - check whether machine type is s390-ccw
> 
> V4 Changes
>  - rebase to current upstream
> 
>  src/qemu/qemu_driver.c  |    6 +-
>  src/qemu/qemu_hotplug.c |  152 +++++++++++++++++++++++++++++++++--------------
>  src/qemu/qemu_hotplug.h |   14 ++---
>  3 files changed, 116 insertions(+), 56 deletions(-)

ACK, though I would have preferred the funtion rename to be a separate
patch.

Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]