[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v4 2/2] conf: Add support for dtb option in QEMU



On 03/13/2013 03:58 PM, Eric Blake wrote:
> On 03/12/2013 10:35 PM, Olivia Yin wrote:
>> Signed-off-by: Olivia Yin <hong-hua yin freescale com>
>>
>> This patch adds support to set the device trees file.
>> ---
> 
>> +      <dt><code>dtb</code></dt>
>> +      <dd>The contents of this element specify the fully-qualified path
>> +        to the (optional) device tree binary (dtb) image in the host OS.
>> +        Since 1.0.4</dd>
> 
> I've added markup that we use in other "since ..." notations, for
> consistency.

Also, I had to squash this in, to keep 'make check' happy:

diff --git i/docs/schemas/domaincommon.rng w/docs/schemas/domaincommon.rng
index 88e89dd..4d97892 100644
--- i/docs/schemas/domaincommon.rng
+++ w/docs/schemas/domaincommon.rng
@@ -367,6 +367,7 @@
             <value>g3beige</value>
             <value>mac99</value>
             <value>prep</value>
+            <value>ppce500v2</value>
           </choice>
         </attribute>
       </optional>

I didn't see anywhere else in our code where we validated against
g3beige or mac99; so for now, I didn't feel too bad adding yet another
unchecked string.  But it seems like someday, we will need to add code
in src/conf/domain_conf.* that lists the entire set of ppc architecture
machine names that we are willing to pass on to qemu, and/or relax the
RNG grammar to support an arbitrary set of machine names the way we do
for arch='x86'.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]