[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 1/3] Fix memory leak on OOM in virSecuritySELinuxMCSFind



On 03/13/2013 12:04 PM, Daniel P. Berrange wrote:
> From: "Daniel P. Berrange" <berrange redhat com>
> 
> The body of the loop in virSecuritySELinuxMCSFind would
> directly 'return NULL' on OOM, instead of jumping to the
> cleanup label. This caused a leak of several local vars.
> 
> Signed-off-by: Daniel P. Berrange <berrange redhat com>
> ---
>  src/security/security_selinux.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

ACK, and a bit surprised Coverity hasn't called us on it.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]