[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] v1:Support for adding a static route to a bridge



On 03/13/2013 04:04 PM, Gene Czarcinski wrote:
This patch adds support for adding a static route for
a network.  The "via" specifies the gateway's IP
address.  Both IPv4 and IPv6 static routes are
supported although it is expected that this
functionality will have more use with IPv6.

Extensive tests are done to validate that the input
definitions are correct.  For example, for a static
route ip definition, the address must be for a network
and not a host.
I have been doing some thinking about the submitted patch and, while it works when everything is as it should be, I believe that there should be some additional checks to ensure that no unexpected code paths are taken (such as if someone would edit a network xml file with vi rather than using virsh net-nedit).

Gene


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]