[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCHv6] virtio-rng: Add rate limiting options for virtio-RNG



On Thu, Mar 14, 2013 at 08:55:52AM +0100, Peter Krempa wrote:
> Qemu's implementation of virtio RNG supports rate limiting of the
> entropy used. This patch exposes the option to tune this functionality.
> 
> This patch is based on qemu commit 904d6f588063fb5ad2b61998acdf1e73fb4
> 
> The rate limiting is exported in the XML as:
> <devices>
>   ...
>   <rng model='virtio'>
>     <rate period='1234'>4321</rate>

You need to update this example


>     <backend model='random'/>
>   </rng>
>   ...
> ---
> 
> Notes:
>     Version 6:
>     - use just attributes in XML instead of mixed attribute/contents
>     - switch rate unit to bytes
>     - tweak the rest to comply with the changes
>     Version 5:
>     - adjust after forbiding arbitrary name passthrough
>     - rebase to master
>     Version 4:
>     - Reword docs
>     - state it is available since 1.0.4 as the tree is frozen and this was actually never acked before
>     Version 3:
>     - State the time unit in docs
>     Version 2:
>     - qemu uses bytes/period, adapt the value according to that
> 
>  docs/formatdomain.html.in                           | 13 +++++++++++++
>  docs/schemas/domaincommon.rng                       | 21 ++++++++++++++++++++-
>  src/conf/domain_conf.c                              | 19 +++++++++++++++++++
>  src/conf/domain_conf.h                              |  2 ++
>  src/qemu/qemu_command.c                             |  8 ++++++++
>  .../qemuxml2argv-virtio-rng-random.args             |  2 +-
>  .../qemuxml2argv-virtio-rng-random.xml              |  1 +
>  7 files changed, 64 insertions(+), 2 deletions(-)


ACK with example in the commit message fixed


Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]