[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] Fix deps for generating RPC dispatch code



On 03/14/2013 08:56 AM, Daniel P. Berrange wrote:
> From: "Daniel P. Berrange" <berrange redhat com>
> 
> The src/lxc/lxc_*_dispatch.h files only had deps on the
> RPC generator script & the XDR definition file. So when
> the Makefile.am args passed to the generator were change,
> the disaptch code was not re-generated. This caused a
> build failure
> 
>   CC       libvirt_lxc-lxc_controller.o
> lxc/lxc_controller.c: In function 'virLXCControllerSetupServer':
> lxc/lxc_controller.c:718:47: error: 'virLXCMonitorProcs' undeclared (first use in this function)
> lxc/lxc_controller.c:718:47: note: each undeclared identifier is reported only once for each function it appears in
> lxc/lxc_controller.c:719:47: error: 'virLXCMonitorNProcs' undeclared (first use in this function)
> make[3]: *** [libvirt_lxc-lxc_controller.o] Error 1
> 
> For added fun, the generated files were not listed in
> CLEANFILES, so only a 'git clean -f' would fix the build
> 
> Pushed as a build break fix

Thanks, and confirmed that this looks right.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]