[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] qemu: detect multi-head qxl via more than version check



On 03/14/2013 08:47 AM, Jiri Denemark wrote:
> On Wed, Mar 13, 2013 at 18:48:46 -0600, Eric Blake wrote:
>> Multi-head QXL support is so useful that distros have started to
>> backport it to qemu earlier than 1.2.  After discussion with
>> Alon Levy, we determined that the existence of the qxl-vga.surfaces
>> property is a reliable indicator of whether '-device qxl-vga' works,
>> or whether we have to stick to the older '-vga qxl'.  I'm leaving
>> in the existing check for QEMU_CAPS_DEVICE_VIDEO_PRIMARY tied to
>> qemu 1.2 and newer (in case qemu is built without qxl support),
> 
> So in other words, QEMU_CAPS_DEVICE_VIDEO_PRIMARY will be set iff qemu
> version is 1.2 or newer or qxl-vga.surfaces exists. That seems fine.

Correct.

> 
> ACK

Thanks; pushed.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]