[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 1/3] qemu: rename virtio-scsi capability



On Thu, Mar 14, 2013 at 04:54:21PM +0100, Viktor Mihajlovski wrote:
> QEMU_CAPS_VIRTIO_SCSI_PCI implies that virtio-scsi is only supported
> for the PCI bus, which is not the case. Remove the _PCI suffix.
> 
> Signed-off-by: Viktor Mihajlovski <mihajlov linux vnet ibm com>
> ---
>  src/qemu/qemu_capabilities.c |    4 ++--
>  src/qemu/qemu_capabilities.h |    2 +-
>  src/qemu/qemu_command.c      |    2 +-
>  tests/qemuhelptest.c         |    6 +++---
>  tests/qemuxml2argvtest.c     |   12 ++++++------
>  5 files changed, 13 insertions(+), 13 deletions(-)
> 
> diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c
> index 79cfdb3..d12ae2e 100644
> --- a/src/qemu/qemu_capabilities.c
> +++ b/src/qemu/qemu_capabilities.c
> @@ -174,7 +174,7 @@ VIR_ENUM_IMPL(virQEMUCaps, QEMU_CAPS_LAST,
>  
>                "bridge", /* 100 */
>                "lsi",
> -              "virtio-scsi-pci",
> +              "virtio-scsi",
>                "blockio",
>                "disable-s3",

No, it is forbidden to change any of these strings once included
in a libvirt release. Changing this will prevent libvirt from
being able to upgrade & restart while VMs are running


Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]