Re: [libvirt] [PATCH 2/4] Fix snapshot-create-as syntax in help output

["Daniel P. Berrange" <berrange redhat com>]

On Thu, Mar 14, 2013 at 10:27:33AM +0100, Martin Kletzander wrote:
> According to the man page, the memspec parameter should have the
> '--memspec' option mandatory and this is as close as we can get to
> that.  What this change does is explained below.
> 
> man virsh:
> 
> snapshot-create-as ... [[--live] [--memspec memspec]]
> 
> virsh help snapshot-create-as before this patch:
> 
>   SYNOPSIS
>     snapshot-create-as ... [<memspec>] ...
> ...
>   OPTIONS
>     [--memspec] <string> ...
> 
> virsh help snapshot-create-as after this patch:
> 
>   SYNOPSIS
>     snapshot-create-as ... [--memspec <string>] ...
> ...
>   OPTIONS
>     --memspec <string> ...
> 
> Signed-off-by: Martin Kletzander <mkletzan redhat com>
> ---
>  tools/virsh-snapshot.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/virsh-snapshot.c b/tools/virsh-snapshot.c
> index d994fd9..c2db99b 100644
> --- a/tools/virsh-snapshot.c
> +++ b/tools/virsh-snapshot.c
> @@ -397,7 +397,7 @@ static const vshCmdOptDef opts_snapshot_create_as[] = {
>       .help = N_("take a live snapshot")
>      },
>      {.name = "memspec",
> -     .type = VSH_OT_DATA,
> +     .type = VSH_OT_STRING,
>       .flags = VSH_OFLAG_REQ_OPT,
>       .help = N_("memory attributes: [file=]name[,snapshot=type]")
>      },

ACK, looks reasonable, but would like Eric to confirm since he did
this bit of code.


Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|