[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 3/4] remove the redundant codes



On Fri, Mar 15, 2013 at 05:03:47PM +0800, Osier Yang wrote:
> >diff --git a/src/util/virnuma.h b/src/util/virnuma.h
> >index b9046c2..8d9f14d 100644
> >--- a/src/util/virnuma.h
> >+++ b/src/util/virnuma.h
> >@@ -22,7 +22,31 @@
> >  #ifndef __VIR_NUMA_H__
> >  # define __VIR_NUMA_H__
> >
> >+#include "virbitmap.h"
> >+
> >+enum virDomainNumatuneMemPlacementMode {
> >+    VIR_DOMAIN_NUMATUNE_MEM_PLACEMENT_MODE_DEFAULT = 0,
> >+    VIR_DOMAIN_NUMATUNE_MEM_PLACEMENT_MODE_STATIC,
> >+    VIR_DOMAIN_NUMATUNE_MEM_PLACEMENT_MODE_AUTO,
> >+
> >+    VIR_DOMAIN_NUMATUNE_MEM_PLACEMENT_MODE_LAST
> >+};

This needs renaming to

   enum  virNumaMemPlacementMode

and the constants to

  VIR_NUMA_MEM_PLACEMENT_MODE*

> >+
> >+typedef struct _virNumaTuneParams virNumaTuneParams;
> >+typedef virNumaTuneParams *virNumaTuneParamsPtr;
> >+struct _virNumaTuneParams {
> >+    struct {
> >+        virBitmapPtr nodemask;
> >+        int mode;
> >+        int placement_mode; /* enum virDomainNumatuneMemPlacementMode */
> >+    } memory;
> >+
> >+    /* Future NUMA tuning related stuff should go here. */
> >+};
> >+
> 
> Except the pointed out nits, others are simply code moving, looks good
> to me. This needs a v2 too.


Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]