[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 06/13] qemu: support URI syntax for NBD



On Mon, Feb 25, 2013 at 06:44:25PM +0100, Paolo Bonzini wrote:
> QEMU 1.3 and newer support an alternative URI-based syntax to specify
> the location of an NBD server.  Libvirt can keep on using the old
> syntax in general, but only the URI syntax supports IPv6 addresses.
> 
> The URI syntax also supports relative paths to Unix sockets.  These
> should never be used but aren't explicitly blocked either by the parser,
> so support it just in case.
> 
> The URI syntax is intentionally compatible with Gluster's, and the
> code can be reused.
> 
> Signed-off-by: Paolo Bonzini <pbonzini redhat com>
> ---
>  src/qemu/qemu_command.c                            | 97 +++++++++++++++-------
>  tests/qemuargv2xmltest.c                           |  2 +
>  ...ml2argv-disk-drive-network-nbd-ipv6-export.args |  5 ++
>  ...xml2argv-disk-drive-network-nbd-ipv6-export.xml | 33 ++++++++
>  .../qemuxml2argv-disk-drive-network-nbd-ipv6.args  |  5 ++
>  .../qemuxml2argv-disk-drive-network-nbd-ipv6.xml   | 33 ++++++++
>  tests/qemuxml2argvtest.c                           |  4 +
>  tests/qemuxml2xmltest.c                            |  2 +
>  8 files changed, 153 insertions(+), 28 deletions(-)
>  create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-disk-drive-network-nbd-ipv6-export.args
>  create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-disk-drive-network-nbd-ipv6-export.xml
>  create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-disk-drive-network-nbd-ipv6.args
>  create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-disk-drive-network-nbd-ipv6.xml

ACK



Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]