[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 1/4] Make vshDebug work when parsing parameters



On 03/15/2013 02:17 PM, Daniel P. Berrange wrote:
> On Fri, Mar 15, 2013 at 02:10:08PM +0100, Martin Kletzander wrote:
>> On 03/14/2013 06:15 PM, Daniel P. Berrange wrote:
>>> On Thu, Mar 14, 2013 at 10:27:32AM +0100, Martin Kletzander wrote:
>>>> The vshInit initializes ctl->debug by which vshDebug (which is also
>>>> called in vshParseArgv) decides whether to print out the message or
>>>> not.
>>>>
>>>> Signed-off-by: Martin Kletzander <mkletzan redhat com>
>>>> ---
[...]
>> diff --git a/tools/virsh.c b/tools/virsh.c
>> index d822e09..58a604b 100644
>> --- a/tools/virsh.c
>> +++ b/tools/virsh.c
>> @@ -3100,12 +3100,12 @@ main(int argc, char **argv)
>>          ctl->name = vshStrdup(ctl, defaultConn);
>>      }
>>
>> -    if (!vshParseArgv(ctl, argc, argv)) {
>> +    if (!vshInit(ctl)) {
>>          vshDeinit(ctl);
>>          exit(EXIT_FAILURE);
>>      }
>>
>> -    if (!vshInit(ctl)) {
>> +    if (!vshParseArgv(ctl, argc, argv)) {
>>          vshDeinit(ctl);
>>          exit(EXIT_FAILURE);
>>      }
> 
> ACK
> 

Thanks, pushed

Martin


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]