[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 4/4] Cleanup useless flags specifications



On 03/14/2013 06:25 PM, Daniel P. Berrange wrote:
> On Thu, Mar 14, 2013 at 10:27:35AM +0100, Martin Kletzander wrote:
>> After we switched to C99 initialization, I noticed there were many
>> places where the specification of .flags parameter differed.  After
>> going through many options and deciding whether to unify the
>> initialization to be '.flags = 0' or '.flags = VSH_OFLAG_NONE', I
>> realized both can be removed and it makes the code easier to go
>> through.
>>
>> Signed-off-by: Martin Kletzander <mkletzan redhat com>
>> ---
>>  tools/virsh-domain-monitor.c |  26 -----
>>  tools/virsh-domain.c         | 221 -------------------------------------------
>>  tools/virsh-host.c           |  10 --
>>  tools/virsh-interface.c      |   7 --
>>  tools/virsh-network.c        |  12 ---
>>  tools/virsh-nodedev.c        |   3 -
>>  tools/virsh-pool.c           |  23 -----
>>  tools/virsh-secret.c         |   4 -
>>  tools/virsh-snapshot.c       |  59 ------------
>>  tools/virsh-volume.c         |  29 ------
>>  tools/virsh.c                |   7 --
>>  11 files changed, 401 deletions(-)
> 
> ACK
> 

Thanks, pushed.

Martin


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]