[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 02/13] qemu: do not support non-network disks without -drive



On Fri, Mar 15, 2013 at 04:56:26PM +0100, Paolo Bonzini wrote:
> Il 15/03/2013 15:43, Eric Blake ha scritto:
> > On 03/15/2013 08:29 AM, Daniel P. Berrange wrote:
> >> On Mon, Feb 25, 2013 at 06:44:21PM +0100, Paolo Bonzini wrote:
> >>> QEMU added -drive in 2007, and NBD in 2008.  Both appeared first in
> >>> release 0.10.0.  Thus the code to support network disks without -drive
> >>> is dead, and in fact it incorrectly escapes commas.  Drop it.
> >>>
> >>> Signed-off-by: Paolo Bonzini <pbonzini redhat com>
> >>> ---
> >>>  src/qemu/qemu_command.c | 53 ++-----------------------------------------------
> >>>  1 file changed, 2 insertions(+), 51 deletions(-)
> >>
> >> ACK
> > 
> > Pushed.
> 
> Ok to push 3-10 and 14 too?  Then I'll send the coding style adjustments
> that Osier requested (but Dan acked nevertheless) and 11-13 which need a
> bit more work.

Nope, not ok to push 7 or 8, given the way it represents IQN & LUN as
separate attributes.

Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]