[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 09/13] qemu: support LUN numbers for iSCSI disks



Il 15/03/2013 16:59, Daniel P. Berrange ha scritto:
>> > I think IQN and LUN are separate things, and best kept separate.  For
>> > example, for each IQN you can only have (if you use -readconfig, which
>> > this series doesn't do) a single username/password/initiator-name triple.
>> > 
>> > Note that the 'name' attribute is already used for the IQN.
> Yes, but that doesn't make it right. The 'name' attribute is intended to
> uniquely identify the exported volume on the server. Neither IQN or LUN
> alone can uniquely identify the volume, so the "name" attribute should
> use a combination of the two. This is the same scenario you have with
> RBD, where you have a 'pool' and 'volume', so the "name" attribute
> uses the "<pool>/<volume>" syntax for identifying the export. In
> retrospect this combined syntax may have been better split up into
> separate attributes, but that's what we have, so we should follow this
> existing practice for iSCSI too.

Ok, that's what I missed.  It should just work in fact, and I'm
explicitly forbidding slashes in patch 8/13; I just need to drop that test.

Paolo


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]