[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] qemu: Fix startupPolicy regression



On Mon, Mar 18, 2013 at 21:33:04 +0800, Guannan Ren wrote:
> On 03/18/2013 09:18 PM, Jiri Denemark wrote:
> > Commit 82d5fe543720da6d83c1d6bfa1c347d7d9fda278
> >
> >      qemu: check backing chains even when cgroup is omitted
> >
> > added backing file checks just before the code that removes optional
> > disks if they are not present. However, the backing chain code fails in
> > case the disk file does not exist, which makes qemuProcessStart fail
> > regardless on configured startupPolicy.
> >
> > Note that startupPolicy implementation is still wrong after this patch
> > since it only check the first file in a possible chain. It should rather
> > check the complete backing chain. But this is an existing limitation
> > that can be solved later. After all, startupPolicy is most useful for
> > CDROM images and they won't make use of backing files in most cases.
> 
>      This fix is also in my patch set, so I give ACK.
> https://www.redhat.com/archives/libvir-list/2013-March/msg00990.html

Oh, I haven't looked at your series yet. I hope you don't mind I pushed
my version since it provides more details about the regression.

Thanks and pushed.

Jirka


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]