[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] storage: fix unlikely memory leak in rbd backend



On 03/18/2013 02:07 PM, Laine Stump wrote:
> virStorageBackendRBDRefreshPool() first allocates an array big enough
> to hold 1024 names, then calls rbd_list(), which returns ERANGE if the
> array isn't big enough. When that happens, the VIR_ALLOC_N is called
> again with a larger size. Unfortunately, the original array isn't
> freed before allocating a new one.
> ---
>  src/storage/storage_backend_rbd.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/src/storage/storage_backend_rbd.c b/src/storage/storage_backend_rbd.c
> index 8a0e517..e815192 100644
> --- a/src/storage/storage_backend_rbd.c
> +++ b/src/storage/storage_backend_rbd.c
> @@ -317,6 +317,7 @@ static int virStorageBackendRBDRefreshPool(virConnectPtr conn ATTRIBUTE_UNUSED,
>              VIR_WARN("%s", _("A problem occurred while listing RBD images"));
>              goto cleanup;
>          }
> +        VIR_FREE(names);

This works, but is possibly less efficient than using VIR_REALLOC_N
instead of VIR_ALLOC_N in the first place.  ACK, since it's not on the
hot path.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]