[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 1/7] Setup LXC cgroups in two phases



On 03/15/2013 12:32 PM, Daniel P. Berrange wrote:
> From: "Daniel P. Berrange" <berrange redhat com>
> 
> Currently the LXC controller creates the cgroup, configures the
> resources and adds the task all in one go. This is not sufficiently
> flexible for the forthcoming NBD integration. We need to make sure
> the NBD process gets into the right cgroup immediately, but we can
> not have limits (in particular the device ACL) applied at the point
> where we start qemu-nbd. So create a virLXCCgroupCreate method
> which creates the cgroup and adds the current ask to be called

s/ask/task

> early, and leave virLXCCgroupSetup to only do resource config.
> 
> Signed-off-by: Daniel P. Berrange <berrange redhat com>
> ---
>  src/lxc/lxc_cgroup.c     | 39 +++++++++++++++++++++++++++------------
>  src/lxc/lxc_cgroup.h     |  4 +++-
>  src/lxc/lxc_controller.c | 12 +++++++++---
>  3 files changed, 39 insertions(+), 16 deletions(-)
> 

ACK - seems reasonable to me.


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]