[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] replace ppce500v2 with ppce500



On Tue, Mar 19, 2013 at 09:05:14PM -0600, Eric Blake wrote:
> On 03/19/2013 08:13 PM, Olivia Yin wrote:
> > ---
> >  docs/schemas/domaincommon.rng                    | 2 +-
> 
> Your commit message is sparse.  This is a good place to explain WHY a
> maintainer should apply your patch.
> 
> On my Fedora 18 box, I see:
> $ qemu-ppc64 -cpu help | grep e500
> PowerPC e500_v10         PVR 80200010
> PowerPC e500_v20         PVR 80200020
> PowerPC e500v1           PVR 80200020
> PowerPC e500v2_v10       PVR 80210010
> PowerPC e500v2_v20       PVR 80210020
> PowerPC e500v2_v21       PVR 80210021
> PowerPC e500v2_v22       PVR 80210022
> PowerPC e500v2           PVR 80210022
> PowerPC e500             PVR 80210022
> PowerPC e500v2_v30       PVR 80210030
> PowerPC e500mc           PVR 80230020
> 
> Doesn't that mean that both 'ppce500' AND 'ppce500v2' (and several
> others) should all be valid machine names?  If anything, we should
> either relax the RNG grammar to allow freeform names (since the code
> wasn't really checking), or we should enhance the grammar and C code to
> call out the entire list of values that qemu supports.  With as many ppc
> variants as qemu seems to support, trying to maintain a list seems like
> duplicated effort where we will constantly be behind.  Therefore, I
> think the best action is to do a mix: relax the grammar to allow any
> string (the way we already do for x86), but then do a validation in the
> C code that the string chosen by the user is supported by qemu (instead
> of the current approach of not caring about the string).

The list of machine names is something we dynamically extract from
QEMU, so the RNG shouldn't be trying to hardcode any list. We shuld
make the RNG allow <text/>

Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]