[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 07/13] domain: add support for iscsi network disks



On 03/11/2013 04:19 AM, Osier Yang wrote:
> On 2013年02月26日 01:44, Paolo Bonzini wrote:
>> This plumbs in the XML description of iSCSI shares.  The next patches
>> will add support for the libiscsi userspace initiator.
>>
>> Signed-off-by: Paolo Bonzini<pbonzini redhat com>
>> ---

>>           the protocol to access to the requested image; possible values
>> -        are "nbd", "rbd", "sheepdog" or "gluster".  If the
>> +        are "nbd", "iscsi", "rbd", "sheepdog" or "gluster".  If the
> 
> Worth to add "<span class="since">since 1.0.4</span>"?

Yes, as follows:

diff --git i/docs/formatdomain.html.in w/docs/formatdomain.html.in
index 397836e..e4ed3f7 100644
--- i/docs/formatdomain.html.in
+++ w/docs/formatdomain.html.in
@@ -1451,7 +1451,8 @@
         or more <code>host</code> sub-elements used to specify the hosts
         to connect.
         <span class="since">Since 0.0.3; <code>type='dir'</code> since
-        0.7.5; <code>type='network'</code> since 0.8.7</span><br/>
+        0.7.5; <code>type='network'</code> since
+        0.8.7; <code>protocol='iscsi'</code> since 1.0.4</span><br/>
         For a "file" disk type which represents a cdrom or floppy
         (the <code>device</code> attribute), it is possible to define
         policy what to do with the disk if the source file is not
accessible.

> 
> ACK with the question kept.

Pushed, and sorry for the delay (I had started pushing the acked portion
of the series last week, then got interrupted halfway through).

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]