[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

[libvirt] [PATCH 1/2] python: treat flags as default argument with value 0



The following four functions have not changed because default arguments
have to come after positional arguments. Changing them will break the
the binding APIs.

migrate(self, dconn, flags, dname, uri, bandwidth):
migrate2(self, dconn, dxml, flags, dname, uri, bandwidth):
migrateToURI(self, duri, flags, dname, bandwidth):
migrateToURI2(self, dconnuri, miguri, dxml, flags, dname, bandwidth):


---
 python/generator.py                          |  2 ++
 python/libvirt-override-virConnect.py        | 14 +++++++-------
 python/libvirt-override-virDomain.py         |  2 +-
 python/libvirt-override-virDomainSnapshot.py |  2 +-
 python/libvirt-override-virStoragePool.py    |  2 +-
 python/libvirt-override.py                   |  2 +-
 6 files changed, 13 insertions(+), 11 deletions(-)

diff --git a/python/generator.py b/python/generator.py
index d269e88..bb53fcf 100755
--- a/python/generator.py
+++ b/python/generator.py
@@ -1487,6 +1487,8 @@ def buildWrappers(module):
                     if n != index:
                         classes.write(", %s" % arg[0])
                     n = n + 1
+                if arg[0] == "flags":
+                    classes.write("=0");
                 classes.write("):\n")
                 writeDoc(module, name, args, '        ', classes)
                 n = 0
diff --git a/python/libvirt-override-virConnect.py b/python/libvirt-override-virConnect.py
index 121ef6f..5495b70 100644
--- a/python/libvirt-override-virConnect.py
+++ b/python/libvirt-override-virConnect.py
@@ -204,7 +204,7 @@
         self.domainEventCallbackID[ret] = opaque
         return ret
 
-    def listAllDomains(self, flags):
+    def listAllDomains(self, flags=0):
         """List all domains and returns a list of domain objects"""
         ret = libvirtmod.virConnectListAllDomains(self._o, flags)
         if ret is None:
@@ -216,7 +216,7 @@
 
         return retlist
 
-    def listAllStoragePools(self, flags):
+    def listAllStoragePools(self, flags=0):
         """Returns a list of storage pool objects"""
         ret = libvirtmod.virConnectListAllStoragePools(self._o, flags)
         if ret is None:
@@ -228,7 +228,7 @@
 
         return retlist
 
-    def listAllNetworks(self, flags):
+    def listAllNetworks(self, flags=0):
         """Returns a list of network objects"""
         ret = libvirtmod.virConnectListAllNetworks(self._o, flags)
         if ret is None:
@@ -240,7 +240,7 @@
 
         return retlist
 
-    def listAllInterfaces(self, flags):
+    def listAllInterfaces(self, flags=0):
         """Returns a list of interface objects"""
         ret = libvirtmod.virConnectListAllInterfaces(self._o, flags)
         if ret is None:
@@ -252,7 +252,7 @@
 
         return retlist
 
-    def listAllDevices(self, flags):
+    def listAllDevices(self, flags=0):
         """Returns a list of host node device objects"""
         ret = libvirtmod.virConnectListAllNodeDevices(self._o, flags)
         if ret is None:
@@ -264,7 +264,7 @@
 
         return retlist
 
-    def listAllNWFilters(self, flags):
+    def listAllNWFilters(self, flags=0):
         """Returns a list of network filter objects"""
         ret = libvirtmod.virConnectListAllNWFilters(self._o, flags)
         if ret is None:
@@ -276,7 +276,7 @@
 
         return retlist
 
-    def listAllSecrets(self, flags):
+    def listAllSecrets(self, flags=0):
         """Returns a list of secret objects"""
         ret = libvirtmod.virConnectListAllSecrets(self._o, flags)
         if ret is None:
diff --git a/python/libvirt-override-virDomain.py b/python/libvirt-override-virDomain.py
index ccc4d5f..142b1d4 100644
--- a/python/libvirt-override-virDomain.py
+++ b/python/libvirt-override-virDomain.py
@@ -1,4 +1,4 @@
-    def listAllSnapshots(self, flags):
+    def listAllSnapshots(self, flags=0):
         """List all snapshots and returns a list of snapshot objects"""
         ret = libvirtmod.virDomainListAllSnapshots(self._o, flags)
         if ret is None:
diff --git a/python/libvirt-override-virDomainSnapshot.py b/python/libvirt-override-virDomainSnapshot.py
index bf708a5..ec53358 100644
--- a/python/libvirt-override-virDomainSnapshot.py
+++ b/python/libvirt-override-virDomainSnapshot.py
@@ -6,7 +6,7 @@
         """Get the domain that a snapshot was created for"""
         return self.domain()
 
-    def listAllChildren(self, flags):
+    def listAllChildren(self, flags=0):
         """List all child snapshots and returns a list of snapshot objects"""
         ret = libvirtmod.virDomainSnapshotListAllChildren(self._o, flags)
         if ret is None:
diff --git a/python/libvirt-override-virStoragePool.py b/python/libvirt-override-virStoragePool.py
index ffe160c..325e403 100644
--- a/python/libvirt-override-virStoragePool.py
+++ b/python/libvirt-override-virStoragePool.py
@@ -1,4 +1,4 @@
-    def listAllVolumes(self, flags):
+    def listAllVolumes(self, flags=0):
         """List all storage volumes and returns a list of storage volume objects"""
         ret = libvirtmod.virStoragePoolListAllVolumes(self._o, flags)
         if ret is None:
diff --git a/python/libvirt-override.py b/python/libvirt-override.py
index 82d7dcb..ccfec48 100644
--- a/python/libvirt-override.py
+++ b/python/libvirt-override.py
@@ -85,7 +85,7 @@ def registerErrorHandler(f, ctx):
        Returns 1 in case of success."""
     return libvirtmod.virRegisterErrorHandler(f,ctx)
 
-def openAuth(uri, auth, flags):
+def openAuth(uri, auth, flags=0):
     ret = libvirtmod.virConnectOpenAuth(uri, auth, flags)
     if ret is None:raise libvirtError('virConnectOpenAuth() failed')
     return virConnect(_obj=ret)
-- 
1.7.11.2


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]