[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] Fix linkage of virt-aa-helper with numa library



On Thu, Mar 21, 2013 at 10:05:50AM +0100, Michal Privoznik wrote:
> On 20.03.2013 17:10, Michal Privoznik wrote:
> > On 20.03.2013 16:02, Daniel P. Berrange wrote:
> >> From: "Daniel P. Berrange" <berrange redhat com>
> >>
> >> The recent commit moved some of the use of libnuma out of the
> >> driver code, and into src/util/. It did not, however, update
> >> libvirt_util.la to link against libnuma. This caused linkage
> >> failure with virt-aa-helper, since nothing else caused libnuma
> >> to be pulled onto the linker command line.
> >>
> >> The fix removes all reference to NUMACTL_LIBS/CFLAGS from the
> >> various modules in src/Makefile.am and just adds them to the
> >> libvirt_util.la module, which everything else depends on.
> >>
> >> Technically a build-breaker fix, but wanted to wait for feedback
> >> on this
> >>
> >> Signed-off-by: Daniel P. Berrange <berrange redhat com>
> >> ---
> >>  src/Makefile.am | 19 ++++++++-----------
> >>  1 file changed, 8 insertions(+), 11 deletions(-)
> >>
> > 
> > ACK
> > 
> > Michal
> 
> Even though I don't like pushing other commiters patches, I've pushed
> this one as it's a build breaker.

Thanks, forgot todo this before i left last night

Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]