[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH RFC 0/5] add support for scsi-generic for virtio-scsi



On 2013年03月04日 14:01, Han Cheng wrote:
> This patch series tried to implement the fifth part of Paolo's proposal:
> 
> http://permalink.gmane.org/gmane.comp.emulators.libvirt/50428
> 
> It is not completed. But it may for use.
> 
> Needs some more works on:
> src/qemu/qemu_hostdev.c
> src/qemu/qemu_hotplug.c
> We may also need create src/util/virscsi.[hc] like
> src/util/vir(pci|usb).[hc], add sg* to nodedev tree and some others.
> 
> As scsi hostdev needs -drive and -device like disk. There are two
> approaches:
> a) build a disk then use the disk related functions,
> b) create new function for it.
> I chose the last one as it is clearer and easier. But this may create
> some redundant codes.

You did right. Except the -drive and -device, I think the other
properties are very different. Mixing them together with disk
will be just confused.

> Any ideas?
> 
> Han Cheng (5):
>    conf: Introduce readonly to hostdev and change helper function
>    conf: Introduce scsi hostdev
>    qemu: New cap flag for scsi-generic
>    qemu: Build qemu command line for scsi-generic
>    tests: tests for scsi hostdev
> 
>   docs/formatdomain.html.in                                              |   36 +-
>   docs/schemas/domaincommon.rng                                          |   38 ++
>   src/conf/domain_audit.c                                                |   10
>   src/conf/domain_conf.c                                                 |  167 +++++++++-
>   src/conf/domain_conf.h                                                 |   13
>   src/libvirt_private.syms                                               |    2
>   src/qemu/qemu_capabilities.c                                           |   15
>   src/qemu/qemu_capabilities.h                                           |    2
>   src/qemu/qemu_command.c                                                |  160 +++++++++
>   tests/qemuhelpdata/qemu-1.0-device                                     |   10
>   tests/qemuhelpdata/qemu-1.1.0-device                                   |   10
>   tests/qemuhelpdata/qemu-1.2.0-device                                   |    5
>   tests/qemuhelpdata/qemu-kvm-1.2.0-device                               |    5
>   tests/qemuhelptest.c                                                   |   19 -
>   tests/qemuxml2argvdata/qemuxml2argv-hostdev-scsi-address-boot.args     |    9
>   tests/qemuxml2argvdata/qemuxml2argv-hostdev-scsi-address-boot.xml      |   34 ++
>   tests/qemuxml2argvdata/qemuxml2argv-hostdev-scsi-address-readonly.args |    9
>   tests/qemuxml2argvdata/qemuxml2argv-hostdev-scsi-address-readonly.xml  |   35 ++
>   tests/qemuxml2argvdata/qemuxml2argv-hostdev-scsi-address.args          |    9
>   tests/qemuxml2argvdata/qemuxml2argv-hostdev-scsi-address.xml           |   34 ++
>   tests/qemuxml2argvtest.c                                               |   12
>   tests/qemuxml2xmltest.c                                                |    4
>   22 files changed, 607 insertions(+), 31 deletions(-)


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]