[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] Correct invalid RNG schemas.



On 03/21/2013 05:00 PM, Ján Tomko wrote:
> On 03/21/2013 04:28 PM, Martin Kletzander wrote:
>> The 'trang' utility, which is able to transform '.rng' files into
>> '.rnc' files, reported some errors in our schemas that weren't caught
>> by the tools we use in the build.  I haven't added a test for this,
>> but the validity can be checked by the following command:
>>
>> trang -I rng -O rnc domain.rng domain.rnc
>>
>> There were unescaped minuses in regular expressions and we were
>> constraining int (which is by default in the range of [-2^31;2^31-1]
>> to maximum of 2^32.  But what we wanted was exactly an unsignedInt.
>>
>> Signed-off-by: Martin Kletzander <mkletzan redhat com>
>> ---
>> Thanks to that, the '.rnc' files can be used by nxml-mode which makes
>> editing libvirt xml files a *lot* easier.
>>
>>  docs/schemas/domaincommon.rng |  2 +-
>>  docs/schemas/nwfilter.rng     | 19 ++++++++-----------
>>  2 files changed, 9 insertions(+), 12 deletions(-)
> 
> ACK
> 
> Jan
> 

Thanks, pushed (and removed the dot at the end of subject).

Martin


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]