[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] nwfilter: probe for inverted ctdir



On 03/21/2013 06:26 PM, Eric Blake wrote:
On 03/21/2013 04:04 PM, Stefan Berger wrote:
C guarantees that this is initialized to false without having to
explicitly state that.

Looks big, but it's a one-time probe done at initialization, and seems
like it does the trick.  You may want to wait for a review from Laine,
but I didn't spot anything else wrong.

One problem:

src/nwfilter/nwfilter_ebiptables_driver.c:4346: if (inet_aton("127.0.0.1", &serveraddr.sin_addr) == 0) {
maint.mk: use inet_aton_r, not inet_aton

I don't think this function exists...


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]