[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 2/2] make: regenerate bindings when <classname>.py changes



On 03/21/2013 06:48 PM, Osier Yang wrote:
On 2013年03月21日 16:41, Guannan Ren wrote:
---
  python/Makefile.am | 9 +++++++--
  1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/python/Makefile.am b/python/Makefile.am
index 55c5e41..18da9a2 100644
--- a/python/Makefile.am
+++ b/python/Makefile.am
@@ -26,7 +26,8 @@ CLASSES_EXTRA = \
      libvirt-override-virConnect.py \
      libvirt-override-virDomain.py \
      libvirt-override-virDomainSnapshot.py \
-    libvirt-override-virStream.py
+    libvirt-override-virStream.py \
+    libvirt-override-virStoragePool.py

ACK to this.


  EXTRA_DIST =            \
      generator.py        \
@@ -109,7 +110,11 @@ LXC_GENERATED= libvirt-lxc-export.c \
         libvirt-lxc.h \
         libvirt_lxc.py

-$(GENERATE).stamp: $(srcdir)/$(GENERATE) $(API_DESC) $(QEMU_API_DESC) $(LXC_API_DESC)
+$(GENERATE).stamp: $(srcdir)/$(GENERATE) \
+                   $(API_DESC) \
+                   $(QEMU_API_DESC) \
+                   $(LXC_API_DESC) \
+                   $(CLASSES_EXTRA)

Why do we need to add the manually created files here?


The problem here is that after we edit or make some changes to these manually-created files,
     then, run make, the libvirt.py wrapper file is not be updated.
The fix here is to update the libvirt.py by running that recipe again, so adding $(CLASS_EXTRA)
     to one of that stamp file's prerequisites.



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]