[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] Remove bogus filtering from virDomainGetRootFilesystem



On 22.03.2013 13:10, Daniel P. Berrange wrote:
> From: "Daniel P. Berrange" <berrange redhat com>
> 
> The virDomainGetRootFilesystem was only returning filesystems
> with type=mount. This is bogus - any type of filesystem is
> valid as the root, if dst=/.
> 
> Signed-off-by: Daniel P. Berrange <berrange redhat com>
> ---
>  src/conf/domain_conf.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
> index 0ef67be..4cae0d3 100644
> --- a/src/conf/domain_conf.c
> +++ b/src/conf/domain_conf.c
> @@ -15635,9 +15635,6 @@ virDomainGetRootFilesystem(virDomainDefPtr def)
>      int i;
>  
>      for (i = 0 ; i < def->nfss ; i++) {
> -        if (def->fss[i]->type != VIR_DOMAIN_FS_TYPE_MOUNT)
> -            continue;
> -
>          if (STREQ(def->fss[i]->dst, "/"))
>              return def->fss[i];
>      }
> 

ACK

Michal


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]