[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] lxc: Prevent shutting down the host

On 03/22/2013 06:17 PM, Daniel P. Berrange wrote:
> On Thu, Mar 21, 2013 at 04:10:45PM +0100, Martin Kletzander wrote:
>> When the container has the same '/dev' mount as host (no chroot),
>> calling domainShutdown(WithFlags) shouldn't shutdown the host it is
>> running on.
>> Signed-off-by: Martin Kletzander <mkletzan redhat com>
>> ---
>> This is also valid for 1.0.[23]-maint branches, so in case this gets
>> ACK'd I'll either send a follow-up for those or push it there as well
>> (if the ACK says so).
>>  src/lxc/lxc_driver.c | 45 ++++++++++++++++++++++++++++-----------------
>>  1 file changed, 28 insertions(+), 17 deletions(-)
> ACK,

Thanks, I pushed it to master, how do you (or anyone else) feel about
the maintenance branches with this patch?

> as a temporary measure. I think we need to make sure that /dev is
> always private for all LXC containers. That can wait for a more
> general refactoring of LXC filesystem setup though.

All the containers should definitely have a private separated
environment, even when no root mount is specified, I meant this as an
interim fix.


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]