[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] lxc: Prevent shutting down the host



On 03/23/2013 09:25 PM, Doug Goldstein wrote:
> On Sat, Mar 23, 2013 at 5:21 AM, Martin Kletzander <mkletzan redhat com> wrote:
>> On 03/22/2013 06:17 PM, Daniel P. Berrange wrote:
>>> On Thu, Mar 21, 2013 at 04:10:45PM +0100, Martin Kletzander wrote:
>>>> When the container has the same '/dev' mount as host (no chroot),
>>>> calling domainShutdown(WithFlags) shouldn't shutdown the host it is
>>>> running on.
>>>>
>>>> Signed-off-by: Martin Kletzander <mkletzan redhat com>
>>>> ---
>>>> This is also valid for 1.0.[23]-maint branches, so in case this gets
>>>> ACK'd I'll either send a follow-up for those or push it there as well
>>>> (if the ACK says so).
>>>>
>>>>  src/lxc/lxc_driver.c | 45 ++++++++++++++++++++++++++++-----------------
>>>>  1 file changed, 28 insertions(+), 17 deletions(-)
>>>
>>> ACK,
>>>
>>
>> Thanks, I pushed it to master, how do you (or anyone else) feel about
>> the maintenance branches with this patch?
>>
> 
> You are welcome to push them into both but the rule of thumb is really
> that once a new release goes out the prior one gets no more love,
> unless someone steps up that it will be a stable series. The idea
> behind the maint branches is really to upstream what the downstreams
> do. e.g. We shipped broken Python bindings in 1.0.2 and every
> downstream that packaged 1.0.2 would have to carry a patch. But how do
> they find out they need to carry that patch if they don't follow the
> developer mailing list closely.
> 

I wasn't sure, but since this is not such a huge deal, I will keep it as
is.  Thanks for the info, now I know for next time ;)

Have a nice day,
Martin


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]