[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v2 0/4]Add startupPolicy attribute support for hard disks

On 03/19/2013 09:55 PM, Guannan Ren wrote:
v1 to v2: added relax schema for disk of block and dir type
           removed original patch 3/5.

The set of patches is trying to add 'startupPolicy' attribute support
to the source element of hard disks. Policy levels are using the
mandatory, requisite, optional levels as originally documented.

For the 'optional' policy, there is a little difference from CDROM and
Floppy which only drop its source path, for disks, if missing, the
checking function will drop their definitions, because qemu doesn't
allow missing source path for hard disk.

If guest is using per-device boot element for its devices, after dropping
one or more bootable device, the boot order will not be contiguous, the way
here I use is to reorder them to make them contiguous. In this way, I
introduce two new bit-operating functions

virBitmapNextLastSetBit: Search for the last set bit before
certain position.

virBitmapNextLastClearBit: Search for the last clear bit before
certain position.

Guannan Ren
  [PATCH v2 1/4] conf: add startupPolicy attribute for harddisk
  [PATCH v2 2/4] util: add two functions to find last set or unset bit in bitmap
  [PATCH v2 3/4] qemu: drop disk definition if missing and reorder per-device boot sequence
  [PATCH v2 4/4] event: add hard disk dropping event reason enum

  docs/formatdomain.html.in     |   9 ++++++---
  docs/schemas/domaincommon.rng |   6 ++++++
  include/libvirt/libvirt.h.in  |   1 +
  src/conf/domain_conf.c        |  21 +++++++++++++++------
  src/conf/domain_conf.h        |   1 +
  src/libvirt_private.syms      |   2 ++
  src/qemu/qemu_domain.c        | 106 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++-----------
  src/util/virbitmap.c          |  96 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
  src/util/virbitmap.h          |   6 ++++++
  tests/virbitmaptest.c         |  51 ++++++++++++++++++++++++++++++++++++++++++++++++++-
  10 files changed, 278 insertions(+), 21 deletions(-)

libvir-list mailing list
libvir-list redhat com

    Does Anybody want to review this?


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]