[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] virsh: Let the compiler check usage of all fields in vshCmdOptType enum



On 03/25/13 19:11, Eric Blake wrote:
On 03/25/2013 10:31 AM, Peter Krempa wrote:
On 03/25/13 17:21, Peter Krempa wrote:
Get rid of the "default" labels to do so.
---
   tools/virsh.c | 4 ----
   1 file changed, 4 deletions(-)


                   case VSH_OT_ALIAS:
                       continue;
-                default:
-                    assert(0);
                   }

                   fprintf(stdout, "    %-15s  %s\n", buf, _(opt->help));


Hum, this patch removes the last two asserts from this file so
syntax-check would fail with this patch. I squashed the removal of

#include <assert.h>

from virsh.c in my private branch.

ACK with that squashed in.  Safe to include in 1.0.4.


Pushed. Thanks.

Peter


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]