[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] Fix virConnectOpen.*() name requirements



On 03/26/2013 03:23 PM, Guannan Ren wrote:
> On 03/26/2013 10:18 PM, Martin Kletzander wrote:
>> On 03/25/2013 05:08 PM, Martin Kletzander wrote:
>>> On 03/25/2013 04:54 PM, Martin Kletzander wrote:
>>>> virConnectOpenAuth didn't require 'name' to be specified (VIR_DEBUG
>>>> used NULLSTR() for the output) and by default, if name == NULL, the
>>>> default connection uri is used.  This was not indicated in the
>>>> documentation and wasn't checked for in other API's VIR_DEBUG outputs.
>>>> ---
>>>> Thanks to Guannan's patch, this makes the following possible in python:
>>>>
>>>> conn = libvirt.open()
>>>>
>>>> which I personally find pretty nice.
>>>> ---
>>> Self-NACK, not quite true, since this function (and some others) are
>>> overridden.  Will send a v2.
>>>
>> Ping, true again after Guannan's patch was modified a bit :)
>>
>> Martin
>>
>> -- 
>> libvir-list mailing list
>> libvir-list redhat com
>> https://www.redhat.com/mailman/listinfo/libvir-list
> 
>     I agree, so I give ACK here.
> 
>     Guannan
> 

Thanks, pushed, since this is very minor change that shouldn't be a
problem to push in the freeze.

Martin


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]