[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCHv2 4/4] virsh: Register and unregister the close callback also in cmdConnect



On 03/27/13 16:05, Peter Krempa wrote:
On 03/27/13 16:00, Viktor Mihajlovski wrote:
On 03/27/2013 03:05 PM, Peter Krempa wrote:
This patch improves the error message after disconnecting from the
hypervisor and adds the close callback operations required not to leak
the callback reference.
---
  tools/virsh.c | 23 +++++++++++++++++------
  1 file changed, 17 insertions(+), 6 deletions(-)


Hi Peter, I see a bunch of errors running make check with this patch
applied (at least in conjunction with my patches).
Mostly:
error: Failed to disconnect from the hypervisor, 1 leaked reference(s)


Hmm, let me check. I might have missed some stuff without noticing :/

Peter

I've re-run the test suite and I'm not getting any errors. I have the current upstream (including your 2/3 patch from v1) and these four on top.

What tests are failing for you?

Peter


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]